Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onehot2bin/bin2onehot encoders in br_arb_rr #171

Closed
zhemao-openai opened this issue Nov 18, 2024 · 1 comment
Closed

Remove onehot2bin/bin2onehot encoders in br_arb_rr #171

zhemao-openai opened this issue Nov 18, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zhemao-openai
Copy link
Contributor

The round robin arbiter stores the last grant used to mark the priority as a binary-encoded signal. This means the timing path has to go through a bin2onehot encoder and then back through onehot2bin encoder before getting updated. We should change to saving the onehot-encoded priority state instead of improve timing.

@zhemao-openai zhemao-openai added enhancement New feature or request good first issue Good for newcomers labels Nov 18, 2024
@zhemao-openai
Copy link
Contributor Author

Fixed by #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant