Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column-comment #452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions drivers/metadata/informationschema/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ func (s InformationSchema) Columns(f metadata.Filter) (*metadata.ColumnSet, erro
s.clauses[ColumnsNumericScale],
s.clauses[ColumnsNumericPrecRadix],
s.clauses[ColumnsCharOctetLength],
"COLUMN_COMMENT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work with PostgreSQL. It needs to be optional, configurable in specific drivers, same as other clauses above:

% go test github.com/xo/usql/drivers/metadata/informationschema/ -cleanup=0
2024/04/13 19:16:23 Could not read pgsql columns: pq: column "column_comment" does not exist
FAIL	github.com/xo/usql/drivers/metadata/informationschema	6.947s
FAIL

}

qstr := "SELECT\n " + strings.Join(columns, ",\n ") + " FROM information_schema.columns\n"
Expand Down Expand Up @@ -253,6 +254,7 @@ func (s InformationSchema) Columns(f metadata.Filter) (*metadata.ColumnSet, erro
&rec.DecimalDigits,
&rec.NumPrecRadix,
&rec.CharOctetLength,
&rec.Comment,
)
if err != nil {
return nil, err
Expand Down
1 change: 1 addition & 0 deletions drivers/metadata/metadata.go
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ type Column struct {
NumPrecRadix int
CharOctetLength int
IsNullable Bool
Comment string
}

type Bool string
Expand Down