Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concatenate - serial comma incorrectly used with two items #63

Open
jsamarziya opened this issue Jun 3, 2022 · 0 comments
Open

concatenate - serial comma incorrectly used with two items #63

jsamarziya opened this issue Jun 3, 2022 · 0 comments

Comments

@jsamarziya
Copy link

Per Wikipedia, a serial comma is

a comma placed immediately after the penultimate term... in a series of three or more terms

We would therefore expect that a serial comma would not be placed by concatenate() when given a sequence of two items, but this is not the case.

Expected:

>>> humanfriendly.text.concatenate(items=["foo", "bar"], serial_comma=True)
'foo and bar'

Actual:

>>> humanfriendly.text.concatenate(items=["foo", "bar"], serial_comma=True)
'foo, and bar'

Workaround:

>>> items = ["foo", "bar"]
>>> humanfriendly.text.concatenate(items=items, serial_comma=len(items) > 2)
'foo and bar'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant