Improve model for sample and marker lists

Author: xoofx

src/Ultra.Core/Model/UGenericList.cs

@@ -4,6 +4,10 @@
 
 using System.Collections;
 using System.ComponentModel;
+using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
+using System.Linq;
+using System.Runtime.CompilerServices;
 using XenoAtom.Collections;
 
 namespace Ultra.Core.Model;
@@ -12,6 +16,8 @@ namespace Ultra.Core.Model;
 /// A generic list class used to store items of type <typeparamref name="T"/>.
 /// </summary>
 /// <typeparam name="T">The type of items in the list.</typeparam>
+[DebuggerDisplay("Count = {Count}")]
+[DebuggerTypeProxy(typeof(UGenericList<>.DebugListView))]
 public abstract class UGenericList<T>(int capacity) : IEnumerable<T>
 {
     /// <summary>
@@ -26,11 +32,29 @@ protected UGenericList() : this(0)
     {
     }
 
+    /// <summary>
+    /// Gets the number of items in the list.
+    /// </summary>
+    public int Count => List.Count;
+
+    /// <summary>
+    /// Gets the item at the specified index.
+    /// </summary>
+    /// <param name="index">The index of the item to get.</param>
+    /// <returns>The item at the specified index</returns>
+    public T this[int index]
+    {
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        get => List[index];
+    }
+
     /// <summary>
     /// Gets the items in the list as a span.
     /// </summary>
     public ReadOnlySpan<T> Items => List.AsSpan();
 
+    /// <inheritdoc />
+    public override string ToString() => $"{GetType().Name}[{Count}]";
 
     /// <summary>
     /// Gets an enumerator for the items in the list.
@@ -42,4 +66,19 @@ protected UGenericList() : this(0)
     IEnumerator<T> IEnumerable<T>.GetEnumerator() => List.GetEnumerator();
 
     IEnumerator IEnumerable.GetEnumerator() => List.GetEnumerator();
+
+    [ExcludeFromCodeCoverage]
+    private sealed class DebugListView(UGenericList<T> genericList)
+    {
+        [DebuggerBrowsable(DebuggerBrowsableState.RootHidden)]
+        public T[] Items
+        {
+            get
+            {
+                T[] array = new T[genericList.Count];
+                genericList.List.CopyTo((Span<T>)array);
+                return array;
+            }
+        }
+    }
 }

src/Ultra.Core/Model/UTraceMarkerList.cs

@@ -0,0 +1,24 @@
+// Copyright (c) Alexandre Mutel. All rights reserved.
+// Licensed under the BSD-Clause 2 license.
+// See license.txt file in the project root for full license information.
+
+namespace Ultra.Core.Model;
+
+/// <summary>
+/// Represents a list of <see cref="UTraceMarker"/>.
+/// </summary>
+public sealed class UTraceMarkerList : UGenericList<UTraceMarker>
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="UTraceMarkerList"/> class.
+    /// </summary>
+    public UTraceMarkerList() : base()
+    {
+    }
+
+    /// <summary>
+    /// Adds a new marker to the list.
+    /// </summary>
+    /// <param name="marker">The sample to add.</param>
+    public void Add(UTraceMarker marker) => List.Add(marker);
+}

src/Ultra.Core/Model/UTraceSampleList.cs

@@ -0,0 +1,24 @@
+// Copyright (c) Alexandre Mutel. All rights reserved.
+// Licensed under the BSD-Clause 2 license.
+// See license.txt file in the project root for full license information.
+
+namespace Ultra.Core.Model;
+
+/// <summary>
+/// Represents a list of <see cref="UTraceSample"/>.
+/// </summary>
+public sealed class UTraceSampleList : UGenericList<UTraceSample>
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="UTraceSampleList"/> class.
+    /// </summary>
+    public UTraceSampleList() : base(1024)
+    {
+    }
+
+    /// <summary>
+    /// Adds a new sample to the list.
+    /// </summary>
+    /// <param name="sample">The sample to add.</param>
+    public void Add(UTraceSample sample) => List.Add(sample);
+}

src/Ultra.Core/Model/UTraceThread.cs

@@ -11,8 +11,6 @@ namespace Ultra.Core.Model;
 /// </summary>
 public sealed record UTraceThread(ulong ThreadID)
 {
-    private UnsafeList<UTraceSample> _samples = new(1024);
-
     /// <summary>
     /// Gets or sets the start time of the thread.
     /// </summary>
@@ -31,21 +29,15 @@ public sealed record UTraceThread(ulong ThreadID)
     /// <summary>
     /// Gets the samples collected for the thread.
     /// </summary>
-    public ReadOnlySpan<UTraceSample> Samples => _samples.AsSpan();
-
-    /// <summary>
-    /// Gets or sets the CPU time for the thread.
-    /// </summary>
-    public UTimeSpan CpuTime { get; set; }
+    public UTraceSampleList Samples { get; } = new();
 
     /// <summary>
-    /// Clears all collected samples.
+    /// Gets the markers collected for the thread.
     /// </summary>
-    public void ClearSamples() => _samples.Clear();
+    public UTraceMarkerList Markers { get; } = new();
 
     /// <summary>
-    /// Adds a new sample to the thread.
+    /// Gets or sets the CPU time for the thread.
     /// </summary>
-    /// <param name="sample">The sample to add.</param>
-    public void AddSample(UTraceSample sample) => _samples.Add(sample);
+    public UTimeSpan CpuTime { get; set; }
 }

src/Ultra.Core/Parser/UltraEventPipeProcessor.cs

@@ -290,7 +290,7 @@ public void RecordStack(UTraceProcess process, UltraNativeCallstackTraceEvent ev
 
             var callStackIndex = process.CallStacks.InsertCallStack(callStack);
 
-            _thread.AddSample(new(callStackIndex, UTimeSpan.FromMilliseconds(evt.TimeStampRelativeMSec), TimeSpan.Zero)); // TODO: cputime
+            _thread.Samples.Add(new(callStackIndex, UTimeSpan.FromMilliseconds(evt.TimeStampRelativeMSec), TimeSpan.Zero)); // TODO: cputime
         }
     }
 }