From e81243c82f9fb4fe8045721c0ca9a4c39b21c9d5 Mon Sep 17 00:00:00 2001 From: Radu Marias Date: Sun, 15 Dec 2024 20:49:27 +0200 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e156b93d..33ab7c93 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -35,13 +35,14 @@ defined in the Apache License shall be dual-licensed as above, without any addit slow, but please give it time to complete as this helps to fix any issues locally and not rely just on running `ci` on GitHub when you create the PR 13. Commit and push your changes, and if there are any errors, fix them before you push them -14. Create a `PR` back to the `parent` repo targeting the `main` branch and request review from +14. Create a `PR` back to the `parent` repo targeting the `main` branch with the title as the GitHub issue title, including `#ID`. Also, include the link to GitHub issue in the description saying like `Fix for ` for bugs or `Implementation for ` for features and others +15. Request review from owners of the repository by adding them to the `Reviewers` field -15. In the project, move the item to `In Code Review` -16. Monitor the checks (GitHub actions runs) and fix the code if they are failing -17. Respond to any comments -18. **DON'T MERGE THE PR YOURSELF. LEAVE THAT TO REPOSITORY OWNERS** -19. In the end, ideally, it will be merged into `main` +16. In the project, move the item to `In Code Review` +17. Monitor the checks (GitHub actions runs) and fix the code if they are failing +18. Respond to any comments +19. **DON'T MERGE THE PR YOURSELF. LEAVE THAT TO REPOSITORY OWNERS** +20. In the end, ideally, it will be merged into `main` # QA manual