Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait for pub API in EncryptedFs #198

Open
radumarias opened this issue Sep 10, 2024 · 2 comments · May be fixed by #200
Open

Trait for pub API in EncryptedFs #198

radumarias opened this issue Sep 10, 2024 · 2 comments · May be fixed by #200
Assignees
@HugoBal
Labels
good first issue Good for newcomers
Milestone
1.0.0-rc1

Comments

@radumarias
Copy link
Member

radumarias commented Sep 10, 2024 •
edited
Loading

Create a trait EncryptedFilesystem which contains all pub methods from EncryptedFs and have docs to use that as a lib.

You need to use async-trait as for now Rust doesn't allow async methods in traits.

Method in EncryptedFs::into_encrypted_filesystem to transform (and consume) self into EncryptedFilesystem.
@radumarias radumarias added the good first issue Good for newcomers label Sep 10, 2024
@radumarias radumarias moved this to Todo in rencfs Sep 10, 2024
@radumarias radumarias added this to the 1.0.0-rc.1 milestone Sep 10, 2024
@HugoBal HugoBal self-assigned this Sep 10, 2024
@HugoBal HugoBal moved this from Todo to In Progress in rencfs Sep 10, 2024
@HugoBal HugoBal linked a pull request Sep 12, 2024 that will close this issue
[198] Trait for pub API in EncryptedFs #200
Draft
@HugoBal
Copy link
Collaborator

HugoBal commented Sep 20, 2024

I started working on this but I am hard stuck on a weird error, which I can't solve. Any help or ideas welcome.
https://github.com/radumarias/rencfs/actions/runs/10910860769/job/30282239881?pr=200

@radumarias
Copy link
Member Author

@HugoBal is this issue still present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HugoBal HugoBal

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
1.0.0-rc1
Development

Successfully merging a pull request may close this issue.

[198] Trait for pub API in EncryptedFs xoriors/rencfs
2 participants
@radumarias @HugoBal