Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests and benchmarks #58

Open
radumarias opened this issue Jul 30, 2024 · 7 comments
Open

Add more tests and benchmarks #58

radumarias opened this issue Jul 30, 2024 · 7 comments
Assignees
@raman4793
Labels
good first issue Good for newcomers tests
Milestone
1.0.0-rc1

Comments

@radumarias
Copy link
Member

radumarias commented Jul 30, 2024 •
edited
Loading

Add more relevant tests and benchmarks here
https://github.com/radumarias/rencfs/blob/main/src/encryptedfs/
https://github.com/radumarias/rencfs/tree/main/src/crypto/write
https://github.com/radumarias/rencfs/tree/main/src/crypto/read
https://github.com/radumarias/rencfs/blob/main/src/arc_hashmap.rs#L96
https://github.com/radumarias/rencfs/blob/main/src/expire_value.rs#L100
https://github.com/radumarias/rencfs/blob/main/src/fs_util.rs
https://github.com/radumarias/rencfs/blob/main/src/keyring.rs
https://github.com/radumarias/rencfs/blob/main/src/mount.rs
https://github.com/radumarias/rencfs/blob/main/src/stream_util.rs

Use criterion, see here how https://github.com/radumarias/rencfs/issues/122

Also add tests with concurrent operations over fs.

https://youtu.be/MiLp0InGOkI?si=xrt3V57DuL1uG2Vr
@radumarias radumarias added documentation Improvements or additions to documentation good first issue Good for newcomers first-timers-only labels Jul 30, 2024
@radumarias radumarias moved this to Todo in rencfs Jul 30, 2024
@radumarias radumarias added tests and removed documentation Improvements or additions to documentation labels Jul 30, 2024
@raman4793 raman4793 moved this from Todo to In Progress in rencfs Jul 30, 2024
@raman4793 raman4793 self-assigned this Jul 30, 2024
@radumarias radumarias added this to the 1.0.0-rc.1 milestone Aug 19, 2024
radumarias pushed a commit that referenced this issue Aug 28, 2024
@raman4793
#58 : Adding tests for crypto::read crypto::write (#187)
02d7dab 
* resolved diverging upstream branch and adding back in the tests
* merging old changes with new changes for read tests
* fixing merge issues in write tests
* more merge fixes
* removing redundant test
@radumarias
Copy link
Member Author

radumarias commented Sep 2, 2024 •
edited
Loading

@raman4793 I added few more places where we need tests and benchmarks

@radumarias radumarias mentioned this issue Sep 2, 2024
Open
@raman4793
Copy link
Collaborator

@raman4793 I added few more places where we need tests and benchmarks

Thank you for the heads-up. I am working on this. Hopefully it can be closed sometime late next week.

@raman4793
Copy link
Collaborator

@radumarias , I am not sure I understand what you meant by use black_box on the input as here. Which package should be I using the black_box on?

@radumarias
Copy link
Member Author

@radumarias , I am not sure I understand what you meant by use black_box on the input as here. Which package should be I using the black_box on?

use test::black_box;

@radumarias
Copy link
Member Author

@raman4793 how are you with this?

@radumarias
Copy link
Member Author

@raman4793 any progress on this?

1 similar comment
@radumarias
Copy link
Member Author

@raman4793 any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raman4793 raman4793

Labels
good first issue Good for newcomers tests
Projects
None yet
Milestone
1.0.0-rc1
Development

No branches or pull requests
2 participants
@raman4793 @radumarias