Query Case Insensitivity

[ndellicarpini]

• made Literals in query params case insensitive
• made layers, layername, and query_layers all aliases of each other
• made srs and crs aliases of each other
• added proper filters in additional_coords for selfe and fvcom grid types
• changed GetLegendInfo.alias to default to False, as it gets set to true anyhow when the request doesn't have a colorscalerange

[ndellicarpini]

not sure how to handle the CI failure except for adding flake8 ignores? those don't seem like valid issues to me

[mpiannucci]

Yeah this is a typing error because the way those new classes evaluate the type checker can not understand. Which kinda kills the point of the type checker at all. I would rather try to find a solution that is typesafe if possible

[mpiannucci]

#119

[mpiannucci]

We can add validators that do the uppercasing and lowercasing to these models instead of messing with the literals

[ndellicarpini]

oh that's an interesting solution, let me see what it looks like once i merge it in

[ndellicarpini]

actually doesn't this approach make trying a request with getmap fail no matter what? I'm not sure if that matters, just not sure why enforcing the capitalization is important. The only reason i tried to fix this is for layerdetails, which the ncwms documentation refers to as layerDetails, and it doesn't work

[mpiannucci]

Yeah currently. If its desired, a validator can be added to handle capitalizing GetMap. But i wouldnt worry about it because thats what the spec says it should be.

Ohhhh i see what you are saying now. Yeah that can be fixed by validators

[ndellicarpini]

Yeah currently. If its desired, a validator can be added to handle capitalizing GetMap. But i wouldnt worry about it because thats what the spec says it should be.

As for layerDetails, that should be fixed by my PR right?

no, your PR lowercases the keys, not the values. idk about lowercasing all of the string values anyhow, could that cause issues down the road?

Edit: I was trying to figure out a way to add a custom validator to all Literal fields, but it looks like the root variable isn't initialized until after validation occurs, so I got hung up trying to get a list of the Literal fields

[mpiannucci]

I would just change it to be layerDetails in the literal for now

[mpiannucci]

Or

    @model_validator(mode="before")
    def validate_item(cls, values: Any) -> Any:
        item = values.get("item")
        if item.lower() == "layerdetails":
            values["item"] = "layerDetails"
        return values

[ndellicarpini]

Well that is what I was trying to avoid, it would be easy enough to add a validator with a manual list of the Literal fields, and then just lowercase the comparison, but that seems annoying to maintain? (granted the requests probably wont change...)

[mpiannucci]

I would rather be explicit about it since its not going to change often

[mpiannucci]

Thanks for this!!!