[eclipse/xtext-core#1835] better treatment of unsupported Java versions in Xtext #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdietrich
force-pushed
the
cd_xtext-core_issue1835
branch
from
5df47a7 to
fb5e1db
Compare
cdietrich
commented
Feb 19, 2022
| @@ -230,12 +230,16 @@ class XtextGradleBuilder implements IncrementalXtextBuilder { | |||
| attachToEmfObject(resourceSet) | |||
| language2GeneratorConfig.putAll( | |||
| gradleRequest.generatorConfigsByLanguage.mapValues [ gradleConfig | | |||
| val javaVersion = JavaVersion.fromQualifier(gradleConfig.javaSourceLevel.toString) | |||
There was a problem hiding this comment.
am not sure how we should react here.
Java 11 as default is not available as we compile against old version.
maybe we should stop here and report error instead?
There was a problem hiding this comment.
Yes, we should make this an error.
cdietrich
force-pushed
the
cd_xtext-core_issue1835
branch
from
fb5e1db to
7f9e7be
Compare
…ns in Xtext Signed-off-by: Christian Dietrich <[email protected]>
cdietrich
force-pushed
the
cd_xtext-core_issue1835
branch
from
7f9e7be to
450bfee
Compare
cdietrich
commented
Mar 31, 2023
| if (javaVersion === null) { | ||
| val msg = "Xtext does not support Java " + gradleConfig.javaSourceLevel.toString + "." | ||
| gradleRequest.logger.error(msg) | ||
| throw new GradleException(msg) |
There was a problem hiding this comment.
is it ok to throw here or should we continue with default and just log error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[eclipse/xtext-core#1835] better treatment of unsupported Java versions in Xtext