-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buy with no sell #4
Comments
Correct....its due to the fact that the current models reward is based on the overall profit made with the buy of shares and then the selling of those same shares. Ofcourse we have the ability to make this reward whatever it is we want as long as it makes sense. |
@xtr33me Should we clean the deque, that is, sell all of remaining in the end of episode, |
Your recommendation completely makes sense and I think it would be a good addition. I personally still think I want to rework the reward in this as well as I don't believe it accounts for enough currently, however I haven't had the time to think about this a lot recently. I am going to keep this open for this task should you or myself get the change made. |
Hi, I have a problem:
If I buy some stock,
and I don't sell them,
I will get no reward, right?
The text was updated successfully, but these errors were encountered: