Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buy with no sell #4

Open
smileyung opened this issue Aug 17, 2018 · 3 comments
Open

Buy with no sell #4

smileyung opened this issue Aug 17, 2018 · 3 comments

Comments

@smileyung
Copy link

Hi, I have a problem:

If I buy some stock,
and I don't sell them,
I will get no reward, right?

@xtr33me
Copy link
Owner

xtr33me commented Aug 17, 2018

Correct....its due to the fact that the current models reward is based on the overall profit made with the buy of shares and then the selling of those same shares. Ofcourse we have the ability to make this reward whatever it is we want as long as it makes sense.

@smileyung
Copy link
Author

@xtr33me
If I buy 100 times, sell 80 times in this episode,
I still remain 20 buy price in the queue(deque),

Should we clean the deque, that is, sell all of remaining in the end of episode,
to have a suitable total profits?

@xtr33me
Copy link
Owner

xtr33me commented Aug 20, 2018

Your recommendation completely makes sense and I think it would be a good addition. I personally still think I want to rework the reward in this as well as I don't believe it accounts for enough currently, however I haven't had the time to think about this a lot recently. I am going to keep this open for this task should you or myself get the change made.

@xtr33me xtr33me closed this as completed Aug 20, 2018
@xtr33me xtr33me reopened this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants