fix: Indicator properties cannot be updated (#818).

xuelongqy · Apr 24, 2024 · 30a5cd7 · 30a5cd7
1 parent 9636869
commit 30a5cd7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 3.3.5+1
+- fix: Indicator properties cannot be updated [#818](https://github.com/xuelongqy/flutter_easy_refresh/issues/818).
+
 ## 3.3.5
 - fix: Material style performance optimization [#814](https://github.com/xuelongqy/flutter_easy_refresh/issues/814).
 - fix: Issue during build when IndicatorStateListenable rebinds IndicatorNotifier [#607](https://github.com/xuelongqy/flutter_easy_refresh/issues/607).

diff --git a/lib/src/notifier/indicator_notifier.dart b/lib/src/notifier/indicator_notifier.dart
@@ -393,10 +393,11 @@ abstract class IndicatorNotifier extends ChangeNotifier {
     if (indicator != null) {
       if (indicator.listenable == _indicator.listenable) {
         indicator.listenable?._rebind(this);
-        return;
       } else {
         _indicator.listenable?._unbind();
         indicator.listenable?._bind(this);
+      }
+      if (indicator != _indicator) {
         _indicator = indicator;
       }
     }

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: easy_refresh
 description: A flutter widget that provides pull-down refresh and pull-up load.
-version: 3.3.5
+version: 3.3.5+1
 homepage: https://xuelongqy.github.io/flutter_easy_refresh
 repository: https://github.com/xuelongqy/flutter_easy_refresh
 issue_tracker: https://github.com/xuelongqy/flutter_easy_refresh/issues