Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws multiple SQL errors in different areas #65

Open
entrptaher opened this issue Dec 9, 2018 · 5 comments
Open

Throws multiple SQL errors in different areas #65

entrptaher opened this issue Dec 9, 2018 · 5 comments

Comments

@entrptaher
Copy link

entrptaher commented Dec 9, 2018

I was testing this out and found multiple errors on the log mostly related to SQL. Here are some,

  • When creating account, ER_NO_DEFAULT_FOR_FIELD for many different fields.
  • When interacting with a hashtag or following/unfollowing a user, ER_FIELD_IN_ORDER_NOT_SELECT.
  • The Explore Users page randomly hangs the whole app.

Another thing is, it says MERN stack but MERN stands for MongoDB, Express, React, NodeJS. Though it's a minor issue. It looks promising, so I might try some PR though.

@entrptaher entrptaher changed the title Throws multiple errors in different areas Throws multiple SQL errors in different areas Dec 9, 2018
@alsong
Copy link

alsong commented Dec 9, 2018

Its open source, am sure the owner wont mind some PRs

@entrptaher
Copy link
Author

One of the fixes I tried was to apply this on SQL. But it's really dangerous.

SET GLOBAL sql_mode = '';

@callofcash
Copy link

Can someone make available a improved version ?

@pmbranco
Copy link

I got it working on my side. You got to change the default values of the user columns, allow null or set a default value.

Also, when creating a post with no group, it tries to insert undefined, and it should be an int. So you got another error. You can fix that by changing the routes/api/post/post-routes.js to check that value for undefined, and if so, change it to 0. Something like this:

    group_id: (group === 'undefined') ? 0 : group,

I believe it has more issues, but I am fixing them as they come up.

@iHaseebRaza
Copy link

anybody got an improved version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants