Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize "Can't buy unit because nowhere to place" #12676

Open
1 task done
metablaster opened this issue Dec 17, 2024 · 6 comments
Open
1 task done

Visualize "Can't buy unit because nowhere to place" #12676

metablaster opened this issue Dec 17, 2024 · 6 comments
Labels

Comments

@metablaster
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Game Version

4.14.16

Describe the bug

In this save file to buy a worker it costs 700 gold.
I have 714 gold but can't buy the worker until next turn.

Steps to Reproduce

  1. Load save file
  2. Go to city Rome
  3. Try to buy worker
  4. The button to buy worker is grayed out until next turn

Screenshots

gold
buy

Link to save file

Rim - 90 poteza-cant-buy.zip

Operating System

Linux

Additional Information

This happened on same turn when settler was built.

@metablaster
Copy link
Contributor Author

metablaster commented Dec 17, 2024

Oh, I just figured out that was because there was settler unit in city tile, sorry!
Maybe the grayed out button should show a tooltip as to why a unit can't be bought?

edit:

I would turn this into feature request and change the title but can't add github labels.

@yairm210 yairm210 changed the title Can't buy worker even though there is enough gold Visualize "Can't buy unit because nowhere to place" Dec 17, 2024
@yairm210
Copy link
Owner

I'm not sure how I would visualize this
Text would be far too big, what would be a good icon for "out of space"?

@metablaster
Copy link
Contributor Author

what would be a good icon for "out of space"?

I found 2 icons on flaticons.com

https://www.flaticon.com/free-icon/crowd_5916375

https://www.flaticon.com/free-icon/crowd_5916332

I like the first one more and sadly there aren't good alternatives out there, maybe someone can find a better one.

@yairm210 yairm210 removed the bug label Dec 22, 2024
@sulai
Copy link
Contributor

sulai commented Jan 8, 2025

I would like to suggest to allow the user to press the button. A dialog shall appear explaining as to why it's not possible to buy a unit right now. This is in line with the confirmation dialog in case a purchase is possible.

As an additional icon to show on the button, maybe something like this?
https://www.flaticon.com/free-icon/prohibition_2478266

@yairm210
Copy link
Owner

yairm210 commented Jan 8, 2025

Oh, interesting 🤔
That could be a theme for other places as well, we should have a "unavailable but clickable for information"-style - probably a grayish-blue, this could fit other "disabled" actions as well (thinking of unit actions)

@sulai
Copy link
Contributor

sulai commented Jan 8, 2025

Or have the button disabled with a clickable question mark next to it.

Another style would serve as well, visually close to a disabled button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants