Add a filter for religions

[SeventhM]

And you get a filter, and you get a filter. Everything gets a multifilter

I mostly thought of this to allow for moving uniques for unlocking religious buildings off of the beliefs themselves and onto the buildings, but almost surely some other modder will find use for it

I really, really, really, really want to find some way to integrate this into city filter (as I believe there is actually a niche case use for that), but I can't figure out how I would go about doing that or if it's just the unique in question needs better alternatives

[yairm210]

For performance, turn this into a switch with all static cases, and have "else" contain the dynamic cases (name, hasMatchingUnique)

[SomeTroglodyte]

... even if you then duplicate the getFounder() call (because it will nevertheless be called at most once - it will even be called "less" if you get to the else). Don't forget that when(filter) { name -> true... works¹, and afterwards it may be simple enough to warrant fun(): T { return x } => fun() = x, which often reads better². Though I admit both hints do have negative precedents in our code - all the matchesSingleFilter I see don't follow them.

Also - aren't the two last if lines absolutely identical?

Footnotes

1. In some other programming languages a switch/case only accepts compile-time constants as branches - e.g. C and C++, but C# could do it via var pattern... ↩

2. Not always - e.g. when the return type is not immediately obvious ↩

[SeventhM]

nevertheless be called at most once - it will even be called "less" if you get to the else). Don't forget that when(filter) { name -> true... works

Java is one such language where switch statements requires a compile-time here if I understand correctly. So that also would compile to an if chain if I understand correctly rather than an actual jvm switch

Also - aren't the two last if lines absolutely identical?

Goddammit

[yairm210]

@SomeTroglodyte context: https://medium.com/@yairm210/kotlin-when-string-optimization-e15c6eea2734

[SomeTroglodyte]

context

Wow. Not really surprising given what 7th just said about Java, but a bit disappointing the compiler won't resolve that itself...

[SomeTroglodyte]

Makes me associate - what was up with interning for Strings in Kotlin? If all strings involved here were interned and coalesced, it wouldn't even need a call to equals(), comparing GC id's or pointers or whatever would be enough, and for the constants part it could precompile a vtable-type thingy. Someone must have determined that all the extra indexing work upsert's overshadows select performance...

[yairm210]

In all JVM languages, interning is not default behavior because it's essentially a hashmap getOrPut which is not cheap
I did consider doing it for RAM purposes but didn't see it made a difference

[SeventhM]

Actually, question: should this accept a civFilter as well? E.g. in cities following a [England] religion. I didn't originally plan on that, and I'm not sure if it's worthwhile to add or not

[yairm210]

I think we can forgo that for now, if no one is asking for it it sounds kind of 'out there'