fix yajra#882 - Due to conflict previous changes were reverted, synchronized repo. #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sudheert7
changed the title
|
I think this change will not execute the sequence syntax and will just return a string instead: Example raw SQLselect 'users_id_seq.currval' as "id" from dual;Output
|
|
fixed, line 154 reverted Output:
|
yajra
reviewed
Sep 9, 2024
| @@ -122,7 +122,7 @@ public function nextValue($name) | |||
|
|
|||
| $name = $this->wrap($name); | |||
|
|
|||
| return $this->connection->selectOne("SELECT $name.NEXTVAL as \"id\" FROM DUAL")->id; | |||
| return $this->connection->selectOne("SELECT '$name.NEXTVAL' as \"id\" FROM DUAL")->id; | |||
There was a problem hiding this comment.
The single quote here is unnecessary and it will produce a bad SQL syntax.
|
Can you please provide snippets to reproduce the issue that is being fixed in this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to conflict previous changes were reverted, synchronized repo.
fix #882