Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Visibility Conditional #2980

Open
1 task done
K8Sewell opened this issue Dec 10, 2024 · 1 comment
Open
1 task done

Refactor Visibility Conditional #2980

K8Sewell opened this issue Dec 10, 2024 · 1 comment
Assignees
@jpengst @K8Sewell
Labels
bug Something isn't working HIGH PRIORITY software engineering

Comments

@K8Sewell
Copy link

K8Sewell commented Dec 10, 2024 •
edited
Loading

Summary

During ingest - CreateNewParentJob - the expected behavior is to be able to ingest objects as Private if certain criteria are not met. This is not happening in practice because the ladybird json included a Open with Permission value in itemPermission. To allow objects to be temporarily ingested as Private this conditional expectation will be removed until Open with Permission can go live in Prod.

Acceptance Criteria

  • Objects with itemPermission in their json can be successfully ingested as private - including dependent child objects

Engineering Notes

Batch Processes

18926 - 18928 on prod

Related Ticket

#2406

Bonus Refactor

duplicate logic - condition 2 and 3
@K8Sewell K8Sewell added bug Something isn't working software engineering labels Dec 10, 2024
@K8Sewell K8Sewell self-assigned this Dec 11, 2024
@K8Sewell K8Sewell mentioned this issue Dec 12, 2024
Open
@K8Sewell K8Sewell changed the title Refactor Default to Private Refactor Visibility Conditional Dec 12, 2024
@K8Sewell
Copy link
Author

PR ready for review - yalelibrary/yul-dc-management#1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpengst jpengst

@K8Sewell K8Sewell

Labels
bug Something isn't working HIGH PRIORITY software engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpengst @K8Sewell @sshetenhelm