Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing global configurations #10

Closed
wants to merge 34 commits into from
Closed

Removing global configurations #10

wants to merge 34 commits into from

Conversation

abrahammurciano
Copy link
Collaborator

@abrahammurciano abrahammurciano commented Aug 15, 2022

Close #11

@abrahammurciano abrahammurciano added this to the v1.0.0 milestone Aug 15, 2022
@abrahammurciano abrahammurciano changed the title WIP: Refactoring install command Removing global configurations Aug 15, 2022
@yamaton
Copy link
Owner

yamaton commented Aug 20, 2022

shlex.quote() is for Unix only. It adds single quotes that do not work with batch scripts on Windows. So better to keep the old utils.quote(), I suppose.

@abrahammurciano
Copy link
Collaborator Author

shlex.quote() is for Unix only. It adds single quotes that do not work with batch scripts on Windows. So better to keep the old utils.quote(), I suppose.

Ah, I was not aware, thanks for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove global configurations
2 participants