Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ODE specification optional #142

Open
shoepfl opened this issue May 7, 2023 · 2 comments
Open

Make ODE specification optional #142

shoepfl opened this issue May 7, 2023 · 2 comments

Comments

@shoepfl
Copy link

shoepfl commented May 7, 2023

Hi,

at the moment the specification of an ODE is mandatory in yaml2sbml, this is problematic when one wants to use explicit equations.

As SBML also supports only the specification of explicit equations, see:
sbmlteam/libsbml#318

I would suggest to make the specification of an ODE optional like an assignment rule.

Thanks for your help

@dilpath
Copy link
Member

dilpath commented May 19, 2023

Hi @shoepfl , sorry for the delay. I just made a PR for this. It looks as simple as editing the file "yaml2sbml/yaml_schema.yaml" and removing the last three lines [1]:

required:
  - odes

This works for me with the following simple example:

time:
      variable: t

assignments:
    - assignmentId: x_1
      formula: exp(t)

[1] https://github.com/yaml2sbml-dev/yaml2sbml/pull/143/files

@shoepfl
Copy link
Author

shoepfl commented May 22, 2023

Hi @dilpath,

ok thanks this looks good and also works for my example :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants