Sprint 3 #42
Open
Sprint 3 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sprint 1
Sprint 2
gennady-bars
reviewed
Oct 7, 2023
There was a problem hiding this comment.
Здравствуйте. (Нужно развернуть общий комментарий ↓)
К сожалению, работу придется отклонить без потери итерации,
- Скрин https://disk.yandex.ru/i/2tHobrSBSDaFNQ Не могу залогиниться. Пишет, что я уже в системе (
User already in system). Значит, произошел автологин, и меня нужно редиректить сразу к чатам:if (err.reason === "User already in system") router.go("/messenger");. Иначе пользователь не поймет, почему не получается войти и не будет знать, как перейти к чатам - Скрин https://disk.yandex.ru/i/uaxnYLlqKXfDJg пулл-реквест нужно делать в свою собственную ветку main, а не в учебный репозиторий практикума
|
Сделайте, пожалуйста, PR в другую ветку, чтобы не приходили уведомления, которые должны приходить, когда кто-то пытается внести в общую ветку Яндекс Практикума |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.