Move s3-credentials check command to ch-monitoring #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| And we execute command on clickhouse01 | ||
| """ | ||
| chadmin ch-s3-credentials check --present | ||
| ch-monitoring s3-credentials-config --present |
There was a problem hiding this comment.
lets also uncomment below. I made separate PR with such changes, but is looks like it can be part of this one.
#262
## Commented because version `latest` will be greater than any other version.
##@require_version_24.11
##Examples:
##|header|
##|access_header|
##
## @require_version_less_than_24.11
There was a problem hiding this comment.
CI tests fail for the latest version on main branch. I'd postpone enabling additional checks until CI get fixed for ClickHouse 24.11.
MikhailBurdukov
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.