Allow creating a new Cluster with alive and down nodes

[nfo]

Scenario:

• I call hasql.NewCluster with three nodes. One node is unreachable ("context deadline exceeded").
• All further calls to Cluster.WaitFor* return an error.
• Calls to Cluster.Alive, Cluster.Primary* and Cluster.Standby* return nil.

Expected: Being able to create a cluster which includes unreachable nodes and still be able to query the alive nodes.

[vtolstov]

do you plan to fix this ?

[bbrodriges]

Yes, there will be fix soon

[vtolstov]

any news ?=)

[bbrodriges]

any news ?=)

Upon deep inspection I can assume that this is a problem with context.Context provided to WaitFor/Alive/Primary. Provided context must be greater than refreshInterval+refreshTimeout duration, in other case ContextDeadlineExceeded will be returned.

As I can see there is no problem with partially available cluster in checkNodes function - https://github.com/yandex/go-hasql/blob/master/check_nodes.go#L96

Can you provide a bit more context to problem, a reproducer may be?

[bbrodriges]

Please read this comment, it may help you to fix the issue.