Feature request: Support log rollover

[vpatibandla-yb]

Today, in odyssey we do not support rollover of logs. Having the support to rollover logs can result in better management of logs. It would be great if the team can implement this feature request. The feature request should work in a multi-threaded odyssey system too i.e, multiple workers are present in odyssey.

Also, what are the ideas to be explored in case log rollover feature has to be implemented in odyssey.

1. Should we use locks to serialize the log write behavior?
2. The async logging in odyssey is disabled today. The reference to the disabled code is present here -

   odyssey/sources/logger.c

   Line 504 in 8090ce8

   if (logger->loaded && false) {

   . Why is this disabled? If this can be enabled and made functional, does it help in an easier implementation of log rollover operations as all the log operations are serialized operations now.

When we do support log rollover, it would be helpful to support multiple configurations on the basis on which log rollover can occur. Some of the important ones are:

1. When the log size reaches a certain configurable value?
2. When the log has to be rolled over at a regular interval?
3. An optional setting can be to create a new log file at the beginning of each day i.e, 12 AM every day.

Also, when the feature is implemented it would be a good idea to have the log directory passed instead of the log file that is passed today. Odyssey can create the log file based on the creation time of the file in the specified log directory. Both the log file and log directory can also be supported together.