Add HBA config file support, add hba reload logic. #442
Conversation
|
Dear maintainers @reshke @usernamedt @x4m ! I wonder if you could take a look to this PR? If you have a time, of course. Despite, it might be looks "ugly", but the implementation almost the same in pgbouncer: The purpose of this PR:
p.s. IMO the performance test with/without that feature would be a nice. |
| @@ -20,17 +20,23 @@ then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| ody-stop | |||
There was a problem hiding this comment.
Errr, does it work? I think we need to stop old instance, right?
There was a problem hiding this comment.
Eithrer way we can remove stop at the end of the file :)
There was a problem hiding this comment.
This change is ok, ody-stop is called in every test
reshke
changed the title
|
LGTM |
| if (isalnum(*parser->pos)) { | ||
| token->type = OD_PARSER_KEYWORD; | ||
| token->line = parser->line; | ||
| token->value.string.pointer = parser->pos; | ||
| while (parser->pos < parser->end && *parser->pos != ',' && | ||
| (isalnum(*parser->pos) || ispunct(*parser->pos))) | ||
| parser->pos++; | ||
| token->value.string.size = | ||
| parser->pos - token->value.string.pointer; | ||
| return token->type; | ||
| } |
There was a problem hiding this comment.
so this is keyword parsing, why is it differs from od_parser_next keyword parsing?
/* keyword */
if (isalpha(*parser->pos)) {
token->type = OD_PARSER_KEYWORD;
token->line = parser->line;
token->value.string.pointer = parser->pos;
while (parser->pos < parser->end &&
(*parser->pos == '_' || isalpha(*parser->pos) ||
isdigit(*parser->pos)))
parser->pos++;
token->value.string.size =
parser->pos - token->value.string.pointer;
return token->type;
}
| for (int i = 0; i < 16; ++i) { | ||
| uint8_t client_net_byte = rule_mask->sin6_addr.s6_addr[i] & | ||
| sin->sin6_addr.s6_addr[i]; | ||
| if (client_net_byte ^ rule_addr->sin6_addr.s6_addr[i]) { |
There was a problem hiding this comment.
Such a strange way to write x == y ?
|
Thanks to @sanyabas for initial implementation and @vadv for putting effort on this to be merged, also thanks @chobostar for review |
add hba support, based on #276.