Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self tests assume git config #39

Open
0-wiz-0 opened this issue Aug 26, 2018 · 0 comments
Open

self tests assume git config #39

0-wiz-0 opened this issue Aug 26, 2018 · 0 comments

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Aug 26, 2018

When running the self tests (for 2.3.4) in a sandbox, I see:

t/clone.t .............. failed to import release, skipping...

*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <foo@bar>) not allowed at inline delegation in Git::CPAN::Patch::Command::Import for git->run (attribute declared in .../Git-CPAN-Patch-2.3.4/blib/lib/Git/CPAN/Patch/Role/Git.pm at line 37) line 18.


    #   Failed test 'branch is there'
    #   at t/clone.t line 74.
    #                   ''
    #     doesn't match '(?^:remotes/cpan/master)'

    #   Failed test 'tag is there'
    #   at t/clone.t line 77.
    #                   ''
    #     doesn't match '(?^:v0.4.)'
    # Looks like you planned 7 tests but ran 2.
    # Looks like you failed 2 tests of 2 run.
t/clone.t .............. 1/2
#   Failed test 'Git-CPAN-Patch'
#   at t/clone.t line 51.
fatal: ambiguous argument 'cpan/master': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]' at /usr/pkg/lib/perl5/vendor_perl/5.28.0/Git/Repository/Plugin/AUTOLOAD.pm line 22.
# Looks like your test exited with 255 just after 1.
t/clone.t .............. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests

If the module wants to use parameters from the user's git config, it should make sure they are there; even better, it should not need them there, because modifying the config to add them would not be good either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant