-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add x-kubernetes-preserve-unknown-fields handling #225
add x-kubernetes-preserve-unknown-fields handling #225
Conversation
specifically using this version of the kubeconform script: yannh/kubeconform#225
Hey @yannh |
Hi @FrancoisPoinsot ! So the issue if I understand it correctly, is that the behavior set by --strict can be overriden in-schema for certain fields, with x-kubernetes-preserve-unknown-fields being set to true or false? |
correct |
Hi @FrancoisPoinsot , sorry for the delayed response - any chance to add a test to ensure this works and doesn't break in the future? Otherwise it looks good to me. |
I will be honest, I am not super familiar with python |
skip setting "additionalProperties: false" when x-kubernetes-preserve-unknown-fields == true
6700f19
to
9f8749e
Compare
I see 2 suites of test. One at the root, called with
The other under The first one has more scenario but only the second one is called from github action. Which one should I extend? edit: Forget that, I see the test for |
Added a couple of test. @yannh , does that look alright to you? |
@yannh should I close that PR? |
skip setting "additionalProperties: false" when x-kubernetes-preserve-unknown-fields == true
This should implement the behavior of https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#controlling-pruning
fixes #224