Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example with cache? #2

Closed
karlhorky opened this issue Aug 13, 2024 · 2 comments · Fixed by #3
Closed

Add example with cache? #2

karlhorky opened this issue Aug 13, 2024 · 2 comments · Fixed by #3

Comments

@karlhorky
Copy link
Contributor

karlhorky commented Aug 13, 2024 •
edited
Loading

First of all, thanks for this project! I will try it out in our projects because non-fixed version specifiers do not guarantee new versions in actions/setup-node

actions/setup-node allows for a cache configuration, which will save the cache of the package manager:

- uses: actions/setup-node@v4
  with:
    cache: 'npm' # also supports 'yarn' and 'pnpm'

What do you think about adding an example with caching too?

Implementation ideas:

  1. Could use actions/cache
  2. Could use the code from the examples and the latest version from the pnpm readme
  3. Could take ideas from my nvm workflow step example
@ybiquitous
Copy link
Owner

PR welcome!

@karlhorky karlhorky mentioned this issue Aug 13, 2024
Merged
@karlhorky
Copy link
Contributor Author

PR open:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cache examples, update to latest actions
2 participants
@ybiquitous @karlhorky