Add parameters WriteMixedBlobThreshold and WriteMixedBlobThresholdSSD #2910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalibin
added
large-tests
yegorskii
reviewed
Jan 23, 2025
cloud/blockstore/libs/storage/partition/part_actor_writeblocks.cpp
Outdated
Show resolved
Hide resolved
agalibin
force-pushed
the
users/agalibin/nbs-2875
branch
2 times, most recently
from
4cdefba to
1c4608e
Compare
yegorskii
reviewed
Jan 23, 2025
|
|
||
| if (requestSize < writeBlobThreshold) { | ||
| if (requestSize < (writeMixedBlobThreshold ? writeMixedBlobThreshold |
There was a problem hiding this comment.
я предлагаю организовать код так:
if (requestSize > writeBlobThreshold) {
пишем merged
} else if (requestSize > writeMixedBlobThreshold) {
пишем mixed
} else {
fresh
}
as minimum request size in bytes to write to the mixed channel.
agalibin
force-pushed
the
users/agalibin/nbs-2875
branch
from
1c4608e to
39144a1
Compare
SvartMetal
reviewed
Jan 24, 2025
| optional uint32 WriteMixedBlobThreshold = 403; | ||
|
|
||
| // Overrides WriteMixedBlobThreshold for SSD volumes. | ||
| optional uint32 WriteMixedBlobThresholdSSD = 404; |
There was a problem hiding this comment.
@agalibin @EvgeniyKozev нужны доказательства того что эти правки улучшают какой-то пользовательский сценарий
|
in pending state: need to implement performance tests before and after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавляет параметры WriteMixedBlobThreshold и WriteMixedBlobThresholdSSD. Это размер запроса в байтах.
С размером меньше WriteMixedBlobThreshold(SSD) будут записаны в fresh канал.
Данные с размером от WriteMixedBlobThreshold(SSD) до WriteBlobThreshold(SSD) будут записаны в mixed канал.
С размером больше WriteBlobThreshold(SSD) будут записаны в merged канал.
По умолчанию выставлены 0, что рассматривается, как фича отключена и надо работать по-старому.
Это первый шаг, далее будет добавлена логика для Compaction.
#2875