Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix forge-std lib and update readme #31

Merged
merged 4 commits into from
Mar 27, 2024
Merged

feat: fix forge-std lib and update readme #31

merged 4 commits into from
Mar 27, 2024

Conversation

0xValJohn
Copy link
Contributor

  • Update forge-std module to master (was causing test issues on fresh install)
  • Add Node.js in readme requirements
  • Improve environment variables section in readme

@Schlagonia
Copy link
Collaborator

Schlagonia commented Mar 25, 2024

  • can you update the installed forg-std dependency too. Not just to submodule file. That way if people directly fork it will be the correct dependency
  • The etherscan API key is not ever actually used. One thing i keep meaning to do is remove it all togethor. Can you delete all reference to ETHERSCAN_API_KEY including the env example, the Make file and the read me?

@0xValJohn
Copy link
Contributor Author

@Schlagonia added in 0d45168 , for your review please

@Schlagonia Schlagonia changed the title Feat: fix forge-std lib and update readme feat: fix forge-std lib and update readme Mar 25, 2024
@Schlagonia
Copy link
Collaborator

just merged a PR on the periphery repo. Since this is already open. Can you also just update the periphery dependency to the latest commit on the master branch.

Should just be an update to BaseHealthCheck. commit: bbc3a0354f45dab087a4c82650e42225433c8fef

@0xValJohn
Copy link
Contributor Author

periphery lib updated

This was referenced Mar 26, 2024
@0xValJohn 0xValJohn closed this Mar 26, 2024
@0xValJohn 0xValJohn deleted the feat--updated-readme-&-forge-std-lib branch March 26, 2024 20:14
@0xValJohn 0xValJohn restored the feat--updated-readme-&-forge-std-lib branch March 27, 2024 12:17
@0xValJohn 0xValJohn reopened this Mar 27, 2024
@Schlagonia Schlagonia merged commit 6c0deeb into yearn:master Mar 27, 2024
4 of 8 checks passed
@0xValJohn 0xValJohn deleted the feat--updated-readme-&-forge-std-lib branch March 27, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants