You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 15, 2022. It is now read-only.
Modify the theme export from dark to something more specific and camelcase, like DarkThemeColors or etc.
the dark theme has a wrong color (extra character)
Modify kebab case to camelcase in color vars, like, primary-variant would be primaryVariant. This is since when used, if it is kebab case, you should have to do dark.colors['primary-variant'] instead of just dark.colors.primaryVariant. And would look inconsistent since with small ones like primary, it will indeed be dark.colors.primary.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Proposed changes:
dark
to something more specific and camelcase, likeDarkThemeColors
or etc.primary-variant
would beprimaryVariant
. This is since when used, if it is kebab case, you should have to dodark.colors['primary-variant']
instead of justdark.colors.primaryVariant
. And would look inconsistent since with small ones like primary, it will indeed bedark.colors.primary
.The text was updated successfully, but these errors were encountered: