You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TL:DR the same issue occurred in jtcop.
Hi, I faced an issue using qulice version 0.23.0 together with org.hamcrest.MatcherAssert.assertThat(String reason, boolean assertion). Qulice fails at test:
@TestvoidroutesNotWhenNotMatchAndNoSpareCmd() {
MatcherAssert.assertThat(
"Routes to command that not matched",
newRouteFork<>(
newFkMatch(false),
newFkCmd(newFkSend())
).route(newFkWrap()).isEmpty()
);
}
With an error:
[INFO] PMD: src/test/java/com/github/artemget/teleroute/route/RouteForkTest.java[56-56]: JUnit assertions should include a message (JUnitAssertionsShouldIncludeMessage)
It forces to write boilerplate Matchers.equalTo(true) or ignoring check every time a test needs to assert that method return true/false because qulice dont see an assertion message (but it is obvious that it exists). For example, this test is valid:
@TestvoidroutesNotWhenNotMatchAndNoSpareCmd() {
MatcherAssert.assertThat(
"Routes to command that not matched",
newRouteFork<>(
newFkMatch(false),
newFkCmd(newFkSend())
).route(newFkWrap()).isEmpty(),
Matchers.equalTo(true)
);
}
@ArtemGet thanks for the report, here is a feedback:
Problems
Ambiguous Title: The bug report's title does not specify the conditions under which the failure occurs or the affected code aspect.
Lack of Environment Details: The bug report does not contain information regarding the environment where the bug occurred, such as the operating system, browser or device type, and software version.
Missing Steps to Reproduce: Despite including the error code, the bug report does not offer clear steps to reproduce the issue, which is essential for developers to duplicate the problem and identify its origin.
I would recommend providing clear, step-by-step instructions on how to reproduce the issue.
Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4
TL:DR the same issue occurred in
jtcop
.Hi, I faced an issue using
qulice
version0.23.0
together withorg.hamcrest.MatcherAssert.assertThat(String reason, boolean assertion)
.Qulice
fails at test:With an error:
It forces to write boilerplate
Matchers.equalTo(true)
or ignoring check every time a test needs to assert that method returntrue
/false
becausequlice
dont see an assertion message (but it is obvious that it exists). For example, this test is valid:Here is GHA log if needed.
The text was updated successfully, but these errors were encountered: