Documentation on Custom SSH Settings is Incorrect/Incomplete

[original-brownbear]

This applies to the documentation here, specifically the SSH section in it:
http://doc.rultor.com/reference.html

The SSH section states:

Your servers must have docker installed. This is the only requirement.

This is not correct. This task should document the missing requirements.
At least this needs to be provided here:

• Efforts will only be made to stay compatible with Docker 1.10.x+ at this point, older versions of Docker might but are not guaranteed to work
• The provided username needs to be in the docker group (so that it can run the docker command) unless it is root
• The SSH key needs to be provided in the Assets, also documented on this page but it should be mentioned here specifically that this path is a path to an asset.

[original-brownbear]

@alex-palevsky this is a bug.

[alex-palevsky]

@alex-palevsky this is a bug.

@original-brownbear I tagged this as "bug"

[alex-palevsky]

@original-brownbear since the ticket has no milestone I set it to 2.0

[alex-palevsky]

@original-brownbear thanks for the report, I topped your acc for 30 mins, payment ID AP-725445163G118414S

[original-brownbear]

@alex-palevsky this is postponed

[original-brownbear]

@yegor256 could you give this one a look please and tell me if I'm not missing the scope here a little?

As of the current state of Rultor, what I ask for being documented here is correct.
But in #1041 (comment) you state that the only requirement for Rultor to run on a host is that it has an available docker cli client.
In that case this ticket would be wrong and I'd have to adjust it to asking to provide a dockerized Git, so to not have the Git requirement. ( I'd like this a lot personally now that this is coming up, would remove another source of randomness from the EC2 host environment and put it fully into Rultor's control)

[alex-palevsky]

@alex-palevsky this is postponed

@original-brownbear right, I added "postponed" label

[alex-palevsky]

@alex-palevsky this is postponed

@original-brownbear no problem, I will try to find somebody else

[yegor256]

@original-brownbear it's up to you. I think that we should ask our users to install as little as possible on their server in order to make them compatible with Rultor. If you can achieve that, do it. If something is not achievable, let's document that requirements in our reference page.

[original-brownbear]

@yegor256 alright Git container it is then :) It's very easy to achieve this actually and in any case in our best interest to have as much control as possible over the environment Rultor works in anyhow I think.
thanks!

Edit: #1060 contains how this can be done btw :)

[yegor256]

@original-brownbear OK thanks