Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Trading Strategies #1

Open
yeonholee50 opened this issue Dec 4, 2024 · 3 comments
Open

More Trading Strategies #1

yeonholee50 opened this issue Dec 4, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@yeonholee50
Copy link
Owner

yeonholee50 commented Dec 4, 2024

This issue will remain. It is open to all contributors. Please make sure your trading strategy isn't already implemented - this can be checked with a quick scan in strategies in helper/client_helper.py - quick ctrl f

Strategies can be added i neither strategies/trading_strategies_v2.py or strategies/trading_strategies_v2_1.py. Please do not add to trading_strategies_v1.py as those strategies are no longer supported. If you wish you can make a new file titled strategies/trading_strategies_v2_2.py and add your strategies there, but this may require additional import statements to other files. When making your strategy, it must abide by these rules:

  • parameters are ticker, current_price, historical_data, account_cash, portfolio_qty, total_portfolio_value in their respective order
  • return format is action, portfolio_qty, ticker
  • If the portfolio quantity is 0, the only valid action is hold or buy. If sell is returned, then this would confuse the ML.

After adding your strategy, please test it in testing_client.py using test_strategies(). you can add your strategy there to test if it will work. If it does, that is great!. If it passes, please add your strategy name to the strategies list in helper/helper_files. That is it, and you can PR and I'll be happy to take a look.

For people interested in training: to add your strategy to MongoDB with appropriate profile, navigate to ranking_client. Run initialize_rank(). Now your strategy has had its profile made in your MongoDB. you may also need to run insert_rank_to_coefficient to initialize the coefficients so that it's on the format rank - coefficient which will help the trading bot retrieve the required voting coefficient for the current ranking it has. If you have any question about this process or the PR in general, please feel free to contact me

@yeonholee50 yeonholee50 added the good first issue Good for newcomers label Dec 4, 2024
@yeonholee50 yeonholee50 pinned this issue Dec 4, 2024
@yeonholee50
Copy link
Owner Author

yeonholee50 commented Dec 7, 2024

Please disregard the first announcement. We will now be using ta-lib's indicator and be using a ranking system on them. Further on, we will be using parameters that are adjustable. Please help my contributing either by adding more strategies not already implemented or the AI portion

@yeonholee50
Copy link
Owner Author

Further idea - make a sentiment strategy - maybe apis from trending on reddit or seeking alpha

@Morritse
Copy link
Contributor

Morritse commented Dec 9, 2024

I have a pretty robust sentiment tracker, will share later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants