Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate comparison to wai-session #18

Open
singpolyma opened this issue Jun 3, 2018 · 0 comments
Open

Inaccurate comparison to wai-session #18

singpolyma opened this issue Jun 3, 2018 · 0 comments

Comments

@singpolyma
Copy link

singpolyma commented Jun 3, 2018

Not a big deal, but just a few nits about the comparison to my wai-session package:

  • wai-session is not only server-side sessions (see, for example, https://hackage.haskell.org/package/wai-session-clientsession)
  • Session ID generation can be done in any way that an application likes, but there is a helper provided (not required to be used) which uses System.Entropy.getEntropy -- so I don't think the helper produces weak session ids, but even if it did it's not required (since sessions IDs aren't even required, see above)
  • Session fixation and lack of session invalidation is true of some backends, the middleware itself doesn't handle this generally for all possible backends, so that's fair of the abstract case
  • There is no out-of-the-box support for TokyoCabinet and never has been -- only out-of-the-box support for in-memory sessions (which are realistically only for testing or very small cases where security is not important) -- backends exist out of package (not "out-of-the-box") for tokyocabinet, postgres, mysql, clientsession, and serversession
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant