ChatHeadless: hide the headless implementation and create a provider layer #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbramblett
changed the title
yen-tt
reviewed
Aug 16, 2023
yen-tt
reviewed
Aug 17, 2023
nbramblett
force-pushed
the
provider-layer
branch
from
2c3aa30
to
94ea77f
Compare
yen-tt
approved these changes
Aug 17, 2023
yen-tt
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified tests pass and that everything builds.
Opted not to build out a provider layer in headless because there isn't anything that needs to be communicated as internal-only. The constructor is sufficient here.
However, there will be a followup PR in chat-headless-react which updates how the headless client is provided and surfaced.