Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics removes dashes on event names #44

Open
1 task done
kaneleeyext opened this issue Mar 21, 2024 · 0 comments
Open
1 task done

Analytics removes dashes on event names #44

kaneleeyext opened this issue Mar 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kaneleeyext
Copy link

Describe the bug

Analytics from @yext/pages/components are applying slugify function on event name of analytics and removing characters such as dashes that some clients need to keep. i.e.) event name "get-offers" is transformed into "getoffers".

Reproduction

No response

System Info

System:
    OS: macOS 13.5.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 717.64 MB / 64.00 GB
    Shell: 3.2.57 - /bin/sh
  Binaries:
    Node: 17.5.0 - ~/.nvm/versions/node/v17.5.0/bin/node
    Yarn: 1.22.22 - /opt/homebrew/bin/yarn
    npm: 8.4.1 - ~/.nvm/versions/node/v17.5.0/bin/npm
    pnpm: 8.14.1 - ~/repo/node_modules/.bin/pnpm
  Browsers:
    Chrome: 123.0.6312.58
    Safari: 17.1
  npmPackages:
    @material/textfield: ^14.0.0 => 14.0.0 
    @originjs/vite-plugin-commonjs: ^1.0.3 => 1.0.3 
    @types/mapbox-gl: ^2.7.11 => 2.7.20 
    @types/react: ^17.0.40 => 17.0.49 
    @types/react-dom: ^17.0.10 => 17.0.17 
    @types/urijs: ^1.19.19 => 1.19.19 
    @typescript-eslint/eslint-plugin: 5.48.2 => 5.48.2 
    @typescript-eslint/parser: 5.48.2 => 5.48.2 
    @vitejs/plugin-react: 1.2.0 => 1.2.0 
    @yext/cobalt: 0.0.1 => 0.0.1 
    @yext/custom-field-debugger: 2.0.9 => 2.0.9 
    @yext/eslint-config: 1.0.0 => 1.0.0 
    @yext/eslint-plugin-export-star: 1.1.0 => 1.1.0 
    @yext/pages: 1.0.0-beta.22 => 1.0.0-beta.22 
    @yext/pages-components: 1.0.0-rc.1 => 1.0.0-rc.1 
    @yext/schema-wrapper: 1.0.2 => 1.0.2 
    @yext/search-headless-react: ^2.1.0 => 2.4.0 
    @yext/search-ui-react: ^1.2.1 => 1.4.1 
    @yext/sites-react-components: ^0.1.16 => 0.1.16 
    @yext/types: 0.1.10-alpha => 0.1.10-alpha 
    autoprefixer: ^10.4.13 => 10.4.13 
    classnames: 2.3.1 => 2.3.1 
    eslint: 8.32.0 => 8.32.0 
    eslint-config-prettier: 8.6.0 => 8.6.0 
    eslint-plugin-react: 7.32.1 => 7.32.1 
    eslint-plugin-react-perf: 3.3.1 => 3.3.1 
    eslint-plugin-tsdoc: 0.2.17 => 0.2.17 
    focus-trap: ^7.5.2 => 7.5.2 
    generate-license-file: ^2.0.0 => 2.0.0 
    husky: ^8.0.0 => 8.0.3 
    i18next: ^23.4.4 => 23.5.0 
    i18next-browser-languagedetector: ^7.1.0 => 7.1.0 
    i18next-conv: ^14.0.0 => 14.0.0 
    i18next-http-backend: ^1.4.4 => 1.4.5 
    i18next-parser: ^8.6.0 => 8.7.0 
    libphonenumber-js: 1.10.14 => 1.10.14 
    mapbox-gl: ^3.0.1 => 3.0.1 
    markdown-to-jsx: ^7.2.0 => 7.2.1 
    plop: ^3.1.1 => 3.1.1 
    pokenode-ts: ^1.13.1 => 1.17.0 
    postcss: ^8.4.12 => 8.4.21 
    postcss-mixins: ^9.0.3 => 9.0.3 
    prettier: ^2.6.2 => 2.7.1 
    pretty-quick: ^3.1.3 => 3.1.3 
    pure-react-carousel: 1.30.1 => 1.30.1 
    react: ^17.0.2 => 17.0.2 
    react-calendar: ^4.6.1 => 4.6.1 
    react-collapsed: 3.6.0 => 3.6.0 
    react-dom: ^17.0.2 => 17.0.2 
    react-i18next: ^13.1.2 => 13.2.2 
    react-router-dom: ^6.3.0 => 6.4.2 
    react-youtube: ^10.1.0 => 10.1.0 
    smartling-api-sdk-nodejs: ^1.5.5 => 1.5.6 
    tailwindcss: 3.2.0 => 3.2.0 
    typed.js: ^2.0.16 => 2.0.16 
    typescript: ^4.6.2 => 4.8.2 
    urijs: ^1.19.11 => 1.19.11 
    vite: 3.0.0 => 3.0.0

Used Package Manager

npm

Used Browser

Chrome

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@kaneleeyext kaneleeyext added the bug Something isn't working label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant