-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(plugin): polyfill upgrade breaking build (#374)
A minor version [change](davidmyersdev/vite-plugin-node-polyfills@abf35b8#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R164) to vite-plugin-node-polyfill adds a dev-only polyfill because it always assumes dev. This breaks the build when generating features because window is undefined. This changes the globals to be polyfilled as "build". --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
- Loading branch information
1 parent
fa613e3
commit d376d4c
Showing
3 changed files
with
14 additions
and
81 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,4 @@ | ||
{ | ||
"features": [ | ||
{ | ||
"name": "turtlehead-tacos", | ||
"templateType": "JS", | ||
"staticPage": {} | ||
}, | ||
{ | ||
"name": "robots", | ||
"templateType": "JS", | ||
"staticPage": {} | ||
}, | ||
{ | ||
"name": "location", | ||
"streamId": "location-stream", | ||
"templateType": "JS", | ||
"entityPageSet": {} | ||
} | ||
], | ||
"streams": [ | ||
{ | ||
"$id": "location-stream", | ||
"filter": { | ||
"entityTypes": [ | ||
"location" | ||
] | ||
}, | ||
"fields": [ | ||
"id", | ||
"uid", | ||
"meta", | ||
"address", | ||
"slug" | ||
], | ||
"localization": { | ||
"locales": [ | ||
"en" | ||
], | ||
"primary": false | ||
} | ||
} | ||
] | ||
"features": [], | ||
"streams": [] | ||
} |
41 changes: 2 additions & 39 deletions
41
playground/multibrand-site/sites-config/sunglasses.oakley.com/features.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,4 @@ | ||
{ | ||
"features": [ | ||
{ | ||
"name": "sunglasses", | ||
"streamId": "oakley-stream", | ||
"templateType": "JS", | ||
"entityPageSet": {} | ||
}, | ||
{ | ||
"name": "turtlehead-tacos", | ||
"templateType": "JS", | ||
"staticPage": {} | ||
}, | ||
{ | ||
"name": "robots", | ||
"templateType": "JS", | ||
"staticPage": {} | ||
} | ||
], | ||
"streams": [ | ||
{ | ||
"$id": "oakley-stream", | ||
"fields": [ | ||
"id", | ||
"name", | ||
"slug" | ||
], | ||
"filter": { | ||
"savedFilterIds": [ | ||
"1241548641" | ||
] | ||
}, | ||
"localization": { | ||
"locales": [ | ||
"en" | ||
], | ||
"primary": false | ||
} | ||
} | ||
] | ||
"features": [], | ||
"streams": [] | ||
} |