-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev/plugin)!: redo reverse proxy setup #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mancusi
suggested changes
Aug 17, 2023
packages/pages/src/vite-plugin/build/buildStart/rendering/templateUtils.ts
Show resolved
Hide resolved
packages/pages/src/vite-plugin/build/closeBundle/bundleValidator.ts
Outdated
Show resolved
Hide resolved
mancusi
reviewed
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the stuff i haven't yet commented on but still a few unresolved conversations
mancusi
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, assets were imported relatively, also taking into account relativePathToPrefix. While this generally worked, there were other issues due to Vite's build optimizations: specifically module preloading and inline assets. Due to this we decided to take a new approach where assets are now imported absolutely and it's now up to the RP config to handle the assets. A working example of a Netlify setup for a RP at the
subdirectory
subfolder looks like this:In order to properly configure the Vite side, a user must set the assetsDir in the vite.config.js (
subdirectory/assets
for the above example) or in the config.yaml (which will be globally supported in some upcoming PRs).Other changes in the PR include a massive refactor of ProjectStructure in order to simplify its usage and is now being used everywhere, meaning that all filenames and folders are fully configurable.