fix(dev): fix dev and tests on Windows #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issues with paths in various places. Convert to posix paths in globSync and Windows paths for filepaths when appropriate. Unit tests pass and npm run dev works as expected. Pages are fully functional and appear the same as on MacOS.
Fixes issues with paths in various places. Convert to posix paths in globSync and Windows paths for filepaths when appropriate. Unit tests pass and npm run dev works as expected. Pages are fully functional and appear the same as on MacOS.
…into fixWindowsTestsAndDev
|
After snapshots get added via github, you need to do an empty commit to trigger tests |
jwartofsky-yext
changed the title
Reran all tests
In several places we compare a hash of the URL, which is different depending on the system.
mkilpatrick
reviewed
Sep 7, 2023
Without this, the method will fail to convert a Windows URL to Posix on Mac.
mkilpatrick
reviewed
Sep 7, 2023
mkilpatrick
reviewed
Sep 8, 2023
mkilpatrick
reviewed
Sep 11, 2023
mkilpatrick
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with paths in various places.
Convert to posix paths in globSync and Windows paths for filepaths when
appropriate.
Unit tests pass and npm run dev works as expected.
Pages are fully functional and appear the same as on MacOS.