Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update vite-plugin-node-polyfills #491

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mkilpatrick
Copy link
Collaborator

This updates vite-plugin-node-polyfills to keep up with fixes. Also addresses a vulnerability found via SemGrep in browserify-sign which is a transitive dependency. This was solved by bumping the minor versions of many transitive deps in pnpm-lock.yaml.

@mkilpatrick mkilpatrick requested a review from a team as a code owner February 26, 2024 23:01
Comment on lines +2973 to +2974
/domain-browser@4.23.0:
resolution: {integrity: sha512-ArzcM/II1wCCujdCNyQjXrAFwS4mrLh4C7DZWlaI8mdh7h3BfKdNd3bKXITfl2PT9FtfQqaGvhi1vPRQPimjGA==}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legal Risk:
domain-browser 4.23.0 was released under the Artistic-2.0 license, a license currently prohibited by your organization. Merging is blocked until this is resolved

Recommendation:
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license

Comment on lines +2973 to +2974
/domain-browser@4.23.0:
resolution: {integrity: sha512-ArzcM/II1wCCujdCNyQjXrAFwS4mrLh4C7DZWlaI8mdh7h3BfKdNd3bKXITfl2PT9FtfQqaGvhi1vPRQPimjGA==}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legal Risk:
domain-browser 4.23.0 was released under the Artistic-2.0 license, a license currently prohibited by your organization. Merging is blocked until this is resolved

Recommendation:
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license

@mkilpatrick
Copy link
Collaborator Author

Tests failing due to davidmyersdev/vite-plugin-node-polyfills#81

@asanehisa
Copy link
Contributor

asanehisa commented Feb 28, 2024

Tests failing due to davidmyersdev/vite-plugin-node-polyfills#81

do we want to wait to merge this change then? so we don't have a bunch of false positive failing tests? the change itself lgtm

@mkilpatrick
Copy link
Collaborator Author

Tests failing due to davidmyersdev/vite-plugin-node-polyfills#81

do we want to wait to merge this change then? so we don't have a bunch of false positive failing tests? the change itself lgtm

No, I'll wait until they release a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants