-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update vite-plugin-node-polyfills #491
base: main
Are you sure you want to change the base?
Conversation
/domain-browser@4.23.0: | ||
resolution: {integrity: sha512-ArzcM/II1wCCujdCNyQjXrAFwS4mrLh4C7DZWlaI8mdh7h3BfKdNd3bKXITfl2PT9FtfQqaGvhi1vPRQPimjGA==} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legal Risk:
domain-browser 4.23.0 was released under the Artistic-2.0 license, a license currently prohibited by your organization. Merging is blocked until this is resolved
Recommendation:
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license
/domain-browser@4.23.0: | ||
resolution: {integrity: sha512-ArzcM/II1wCCujdCNyQjXrAFwS4mrLh4C7DZWlaI8mdh7h3BfKdNd3bKXITfl2PT9FtfQqaGvhi1vPRQPimjGA==} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legal Risk:
domain-browser 4.23.0 was released under the Artistic-2.0 license, a license currently prohibited by your organization. Merging is blocked until this is resolved
Recommendation:
Reach out to your security team or Semgrep admin to address this issue. In special cases, exceptions may be made for dependencies with violating licenses, however, the general recommendation is to avoid using a dependency under such a license
Tests failing due to davidmyersdev/vite-plugin-node-polyfills#81 |
do we want to wait to merge this change then? so we don't have a bunch of false positive failing tests? the change itself lgtm |
No, I'll wait until they release a fix. |
This updates vite-plugin-node-polyfills to keep up with fixes. Also addresses a vulnerability found via SemGrep in browserify-sign which is a transitive dependency. This was solved by bumping the minor versions of many transitive deps in pnpm-lock.yaml.