entity_unmarshal: Check if type is struct before calling NumField() #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdworak
reviewed
Mar 28, 2019
| field := val.Type().Field(i) | ||
| tag := strings.Replace(field.Tag.Get("json"), ",omitempty", "", -1) | ||
| jsonTagToKey[tag] = field.Name | ||
| if val.Kind() == reflect.Struct { |
There was a problem hiding this comment.
this if statement should probably wrap everything i think in this function, because the part you wrapped generates jsonTagToKey and that part is used in the second part (so if we don't actually populate jsonTagToKey there's no use in doing this part.
Do you have an example for which this was breaking? Should we add something to the entity_test.go file?
There was a problem hiding this comment.
yes that makes sense--I've updated it! I've also added google attributes to the test. prior to my fix, adding google attributes resulted in a panic when trying to run the tests
xzou
force-pushed
the
entities-unmarshalNonStructs
branch
from
40c0aef
to
509e2ae
Compare
cdworak
approved these changes
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.