Image comparison: use source url #129
Conversation
| func (a *Image) Equal(b Comparable) bool { | ||
| defer func() { | ||
| if r := recover(); r != nil { | ||
| log.Printf("Value of A: %+v, Value of B:%+v, Type Of A: %T, Type Of B: %T\n", a, b, a, b) |
There was a problem hiding this comment.
Yeah, it follows the model of the other Equal implementations in yext-go
| }() | ||
|
|
||
| if a.SourceUrl != nil { | ||
| a.Url = a.SourceUrl |
There was a problem hiding this comment.
mutating the source seems wacky - can we compare the source URL directly?
There was a problem hiding this comment.
sure but i wanted to make sure it was only the source url and url that is different, i don't have a great way of doing that other than porting reflection here (the diff) or writing code to compare attribute to attribute, which if we add an attribute we'd have to remember to update this code too, so that seems dangerous
|
I think if ------- doesn't update their source than we should probably add a vparam to the end of the URL with today's date and we'd essentially have no change of functionality. For clients that do update their source we get duplicate updates, which messes with stats and fills the db unnecessarily, so I'd prefer the vparam route if possible. |
| }() | ||
|
|
||
| if a.SourceUrl != nil { | ||
| a.Url = a.SourceUrl |
There was a problem hiding this comment.
I'm uncomfortable with the idea of the equal function modifying the receiver that it's called on? could we copy it instead and then call genericdiff on the copy?
You mean modify their source URL? How so? |
|
Just want to add another use case, ---- also has an etl that updates images without updating the url |
|
We could make this opt-in (or out) by using a property on the image itself? e.g. |
|
Another potential avenue would be to add a hash property on the image itself and use that for diffing if it's populated. That would allow us to have calling code handle it by downloading the image and creating a hash of the contents to diff against for cases where we don't get changed URLs and when we do get changed URLs we can just set the hash to the url itself. |
No description provided.