Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type.go #98

Open
wants to merge 1 commit into
base: entities
Choose a base branch
from
Open

Update type.go #98

wants to merge 1 commit into from

Conversation

bhainesva
Copy link
Contributor

@bhainesva bhainesva commented Mar 1, 2019

Can we do this

@bhainesva bhainesva requested a review from cdworak March 1, 2019 19:26
@cdworak
Copy link
Contributor

cdworak commented Mar 1, 2019

Per discussion offline, I think if we need to handle a nil then this should return nil rather than []string{}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants