normaliseconf flag removes existing values

[tbitcomb]

The behavior of -normaliseconf seems to have changed between v4 and v5.

I used to be able to have a generic config that I could then use that argument on to generate a key for while leaving everything in tact:

cat yggdrasil.conf | yggdrasil -useconf -normaliseconf > yggdrasil.conf

For instance, if I have a sort of "template" config with peers and node info set up, but without a private key, the above used to add the key but leave the rest alone.

After I upgraded to 0.5.5, it now adds the key but erases my defaults, replacing them with empty lists and such. This is true even with a config that was initially generated by v0.5.5.

EDIT: This might specifically involve the version available for Alpine Linux, as this does not seem to be a problem on macOS.

[neilalexander]

Does this happen if you do yggdrasil -useconffile yggdrasil.conf -normaliseconf > yggdrasil.conf instead?

[klemensn]

Does this happen if you do yggdrasil -useconffile yggdrasil.conf -normaliseconf > yggdrasil.conf instead?

Your shell will truncate the file before yggdrasil reads it.
This does not do what you think it does.

$ echo garbage >| yggdrasil.conf
$ yggdrasil -useconffile yggdrasil.conf -normaliseconf          
panic: json: cannot unmarshal string into Go value of type config.NodeConfig

goroutine 1 [running]:
main.main()
	github.com/yggdrasil-network/yggdrasil-go/cmd/yggdrasil/main.go:114 +0x23da
$ yggdrasil -useconffile yggdrasil.conf -normaliseconf >| yggdrasil.conf
$ echo $?
0