Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classNameAtMax and stylesAtMax #37

Open
a-tonchev opened this issue Jun 9, 2021 · 8 comments
Open

Add classNameAtMax and stylesAtMax #37

a-tonchev opened this issue Jun 9, 2021 · 8 comments
Assignees
Labels
feature request New feature or request
Milestone

Comments

@a-tonchev
Copy link
Contributor

a-tonchev commented Jun 9, 2021

Since we have className and styles for non-maximized view, it should be nice to have also such ones for maximized view.

I love the way material ui is doing this with the classes object:

https://material-ui.com/customization/components/

I think best would be something like

<Carousel
  classnames={{
    thumbnail: classNameOfThumbnail,
    activeThumbnail: classNameOfActiveThumbnail,
    maximizedCarousel: classNameOfMaximizedCarousel,
    image: classNameOfImage,
    imageContainer: classNameOfImageContainer,
    ...etc
  }}
>
@yifaneye
Copy link
Owner

yifaneye commented Jun 9, 2021

Hi @a-tonchev ! Thank you for bringing this issue up! 😄

The way you suggested should work great! I will add this probably in v0.3.0.

@yifaneye yifaneye self-assigned this Jun 9, 2021
@yifaneye yifaneye added the feature request New feature or request label Jun 9, 2021
@yifaneye yifaneye added this to the v0.3.0 milestone Jun 9, 2021
@Ruslan27032000
Copy link

Hi. Do you gonna release v0.3.0?

@yifaneye
Copy link
Owner

I am a bit busy at the moment. I will work on it this month or the next.

@Ruslan27032000
Copy link

@yifaneye Do you need any help for realization?)

@yifaneye
Copy link
Owner

@Ruslan27032000 Thanks for asking. It will be awesome if you can make a pull request.

@Ruslan27032000
Copy link

@yifaneye I tried to make the right styles but I think you can do it better

@yifaneye
Copy link
Owner

@Ruslan27032000 Thanks! Please make a pull request, so I can try to enhance it.

@yifaneye
Copy link
Owner

Hi @Ruslan27032000 !

Could you please create a pull request to merge into the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants