Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Oracle column type #735

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Aug 4, 2023

Fix types in test

Required for yiisoft/db-oracle#230

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Aug 4, 2023

PR Summary

  • Enhancements to the OCI Column Types in ColumnTypes.php

    • Precision values were added to the existing OCI column types, offering increased accuracy in data storage.
    • Additionally, NUMBER column types now include both precision and scale values which are beneficial for decimal and numeric data usage.
    • The TIMESTAMP column type now includes precision value enhancement, which provides better time-related data handling.
    • Newly introduced column types, BINARY_DOUBLE and BINARY_FLOAT, expands options for handling binary data types.
  • Expansion of Timestamp Capabilities

    • There is a new column type, timestamp(4), usable for pgsql and oci databases. This enables handling of time-series data with increased granularity.
  • Precision Enhancements for oci and sqlsrv DBs

    • timestamp and time column types now include precision value for oci and sqlsrv databases. This results in close targeting of time data representations.
    • Also, time column types for oci and sqlsrv databases have been upgraded to use INTERVAL DAY(0) TO SECOND(0) instead of TIMESTAMP. This optimization enhances the temporal data handling capabilities.
  • Documentation Updates

    • The doc block comments have been enriched to include mentions of the new TIMESTAMP(4) column type for OCI.

Enhancements in this PR are mainly about providing better precision in handling of numerical and temporal data types, and expanding options for binary data handling in different databases.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (c5aa0b1) 89.59% compared to head (8837966) 89.64%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #735      +/-   ##
============================================
+ Coverage     89.59%   89.64%   +0.05%     
  Complexity     1375     1375              
============================================
  Files            67       67              
  Lines          3382     3380       -2     
============================================
  Hits           3030     3030              
+ Misses          352      350       -2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review August 4, 2023 16:43
@terabytesoftw terabytesoftw merged commit fb4c084 into yiisoft:master Sep 2, 2023
9 of 11 checks passed
@Tigrov Tigrov deleted the improve_oracle_column_type branch September 3, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants