Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make $content optional in Button factories #223

Closed
vjik opened this issue Oct 22, 2024 · 4 comments · Fixed by #238
Closed

Make $content optional in Button factories #223

vjik opened this issue Oct 22, 2024 · 4 comments · Fixed by #238
Assignees
@FrankiFixx
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@vjik
Copy link
Member

vjik commented Oct 22, 2024 

Button::button();
Button::submit();
Button::reset();
@vjik vjik added the type:enhancement Enhancement label Oct 22, 2024
@samdark
Copy link
Member

samdark commented Oct 22, 2024

What's the goal of a button without any content?

@vjik
Copy link
Member Author

vjik commented Oct 22, 2024

Button can be styled by CSS

What's the goal of a button without any content?

@samdark
Copy link
Member

samdark commented Oct 22, 2024

Alright. Makes sense.

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Oct 22, 2024
@FrankiFixx
Copy link
Contributor

Work on it

@vjik vjik mentioned this issue Jan 19, 2025
Merged
@vjik vjik closed this as completed in #238 Jan 19, 2025
@vjik vjik closed this as completed in cc467a7 Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankiFixx FrankiFixx

Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #223: Make $content optional in Button factories FrankiFixx/html
3 participants
@samdark @vjik @FrankiFixx