From 7fd59cd663115b15407be4fa6c322e07990c84e6 Mon Sep 17 00:00:00 2001 From: jisse Reitsma Date: Fri, 21 Jul 2023 16:26:05 +0200 Subject: [PATCH] Prevent JS error `Cannot read properties of undefined` under Hyva #181 --- CHANGELOG.md | 4 ++++ composer.json | 2 +- view/frontend/templates/hyva/script-additions.phtml | 6 ++++-- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ca0f983..4e381053 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [3.5.6] - 21 July 2023 +### Fixed +- Prevent JS error `Cannot read properties of undefined` under Hyva #181 + ## [3.5.5] - 21 July 2023 ### Fixed - Make sure that shipment code is added, if missing in address diff --git a/composer.json b/composer.json index 35b62aa1..51808f9e 100644 --- a/composer.json +++ b/composer.json @@ -1,6 +1,6 @@ { "name": "yireo/magento2-googletagmanager2", - "version": "3.5.5", + "version": "3.5.6", "license": "OSL-3.0", "type": "magento2-module", "homepage": "https://www.yireo.com/software/magento-extensions/googletagmanager2", diff --git a/view/frontend/templates/hyva/script-additions.phtml b/view/frontend/templates/hyva/script-additions.phtml index 274c2019..69b3043b 100644 --- a/view/frontend/templates/hyva/script-additions.phtml +++ b/view/frontend/templates/hyva/script-additions.phtml @@ -60,10 +60,12 @@ $commons = $block->getCommonsViewModel(); mageCacheStorage = JSON.parse(mageCacheStorage); } - if (typeof mageCacheStorage.cart.gtm_events[eventId] !== undefined) { + if (mageCacheStorage !== null && + typeof mageCacheStorage.cart !== undefined && + typeof mageCacheStorage.cart.gtm_events[eventId] !== undefined) { delete mageCacheStorage.cart.gtm_events[eventId]; } - + window.localStorage.setItem('mage-cache-storage', JSON.stringify(mageCacheStorage)); } }