Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25: Product duplicates in wishlist after user login #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #25: Product duplicates in wishlist after user login #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions includes/data-stores/class-yith-wcwl-wishlist-data-store.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,7 @@ public function assign_to_user( $session_id, $user_id ) {
if ( ! empty( $items ) ) {
$items_string = implode( ',', array_map( 'esc_sql', $items ) );
$wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->yith_wcwl_items} SET user_id = %d WHERE ID IN ({$items_string})", $user_id ) ); // phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$this->clear_up_duplicate_items($user_id);
}

// set user id for any session wishlist, and remove session data.
Expand Down Expand Up @@ -1292,6 +1293,24 @@ protected function clear_caches( &$wishlist ) {
wp_cache_delete( 'user-wishlists-' . $session_id, 'wishlists' );
}
}

protected function clear_up_duplicate_items( int $user_id )
{
global $wpdb;

$wpdb->query(
$wpdb->prepare('DELETE FROM ' . $wpdb->yith_wcwl_items .
' WHERE user_id = %1$d AND ID NOT IN (
SELECT min_id
FROM (
SELECT user_id, prod_id, wishlist_id, MIN(ID) AS min_id
FROM ' . $wpdb->yith_wcwl_items .
' WHERE user_id = %1$d
GROUP BY user_id, wishlist_id, prod_id
) AS subquery
)', $user_id)
);
}
}
}

Expand Down