Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knn confusion #8

Open
HengYuh opened this issue Mar 3, 2024 · 0 comments
Open

knn confusion #8

HengYuh opened this issue Mar 3, 2024 · 0 comments

Comments

@HengYuh
Copy link

HengYuh commented Mar 3, 2024

hello,I think this place in knn part :
for i in range(N):
X_train_folds.append(X_train[i*length: (i+1)length])
y_train_folds.append(y_train[i
length: (i+1)length])
may should be:
for i in range(num_folds):
X_train_folds.append(X_train[i
length: (i+1)length])
y_train_folds.append(y_train[i
length: (i+1)*length])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant