From 669e0a79550766030d7e573b45c41176bb9d1266 Mon Sep 17 00:00:00 2001
From: Toke Stuart Jepsen <tokejepsen@gmail.com>
Date: Thu, 22 Feb 2024 13:16:30 +0000
Subject: [PATCH] Add OP settings and convert in plugin

---
 .../plugins/publish/collect_clip_effects.py   | 10 +++++---
 .../defaults/project_settings/hiero.json      |  4 +++
 .../projects_schema/schema_project_hiero.json | 25 +++++++++++++++++++
 3 files changed, 36 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/hiero/plugins/publish/collect_clip_effects.py b/openpype/hosts/hiero/plugins/publish/collect_clip_effects.py
index d7f646ebc9f..44767e458ac 100644
--- a/openpype/hosts/hiero/plugins/publish/collect_clip_effects.py
+++ b/openpype/hosts/hiero/plugins/publish/collect_clip_effects.py
@@ -72,9 +72,13 @@ def process(self, instance):
 
         subset_split.insert(0, "effect")
 
-        effect_categories = {
-            x["name"]: x["effect_classes"] for x in self.effect_categories
-        }
+        # Need to convert to dict for AYON settings. This isinstance check can
+        # be removed in the future when OpenPype is no longer.
+        effect_categories = self.effect_categories
+        if isinstance(self.effect_categories, list):
+            effect_categories = {
+                x["name"]: x["effect_classes"] for x in self.effect_categories
+            }
 
         category_by_effect = {"": ""}
         for key, values in effect_categories.items():
diff --git a/openpype/settings/defaults/project_settings/hiero.json b/openpype/settings/defaults/project_settings/hiero.json
index 9c83733b096..efd80a8876d 100644
--- a/openpype/settings/defaults/project_settings/hiero.json
+++ b/openpype/settings/defaults/project_settings/hiero.json
@@ -69,6 +69,10 @@
             "tags_addition": [
                 "review"
             ]
+        },
+        "CollectClipEffects": {
+            "enabled": true,
+            "effect_categories": {}
         }
     },
     "filters": {},
diff --git a/openpype/settings/entities/schemas/projects_schema/schema_project_hiero.json b/openpype/settings/entities/schemas/projects_schema/schema_project_hiero.json
index d80edf902b2..73bd475815a 100644
--- a/openpype/settings/entities/schemas/projects_schema/schema_project_hiero.json
+++ b/openpype/settings/entities/schemas/projects_schema/schema_project_hiero.json
@@ -312,6 +312,31 @@
                             "label": "Tags addition"
                         }
                     ]
+                },
+                {
+                    "type": "dict",
+                    "collapsible": true,
+                    "checkbox_key": "enabled",
+                    "key": "CollectClipEffects",
+                    "label": "Collect Clip Effects",
+                    "is_group": true,
+                    "children": [
+                        {
+                            "type": "boolean",
+                            "key": "enabled",
+                            "label": "Enabled"
+                        },
+                        {
+                            "type": "dict-modifiable",
+                            "key": "effect_categories",
+                            "label": "Effect Categories",
+                            "object_type": {
+                                "type": "list",
+                                "key": "effects_classes",
+                                "object_type": "text"
+                            }
+                        }
+                    ]
                 }
             ]
         },